Skip to content

Conversation

jop611
Copy link

@jop611 jop611 commented Aug 22, 2024

Performance changes to consistent and assemble.

@jop611 jop611 changed the title Modified consistent/assemble Fixed performance issues in consistent/assemble, new and improved distributed sparse matrix multiplication algorithms. Jan 27, 2025
@@ -948,9 +948,9 @@ parallel implementations.

# Properties

- `matrix_partition::A`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed?

Copy link
Author

@jop611 jop611 Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first line of the doc string says struct PSparseMatrix{V,B,C,D,T}, and the first property used to say matrix_partition::A, but A it not an existing field, so to me it feels like my changes are correct, and the existing documentation is not.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of "type piracy in this file". One cannot define methods for functions and types in other packages.

If you want to work with your own versions of the functions, then you need to consider different function names.

Copy link
Author

@jop611 jop611 Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I resolved this now, but this probably means that *,\, +, - do not behave as expected for SparseMatrixCSR structs. mul! is replaced by matmul!, which I believe is not exported by any library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants